fix: support nmredata extension #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jobo322
commented
Sep 21, 2023
•
jobo322
commented
- .nmredata files as a sdf instead of a nmrRecord.
- .nmredata and .sdf file extension will be checked if contains nmredata information.
2 tasks
Deploying with
|
| Latest commit: |
f2aa254
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://778819ef.nmrium.pages.dev |
| Branch Preview URL: | https://2647-issues-parsing-nmredata.nmrium.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2692 +/- ##
=======================================
Coverage 53.65% 53.65%
=======================================
Files 51 51
Lines 2462 2462
Branches 88 88
=======================================
Hits 1321 1321
Misses 1140 1140
Partials 1 1 ☔ View full report in Codecov by Sentry. |
2 tasks
lpatiny
reviewed
Sep 21, 2023
jobo322
force-pushed
the
2647-issues-parsing-nmredata-file-associated-with-bruker-zip-file
branch
from
3aea233 to
888d820
Compare
jobo322
force-pushed
the
2647-issues-parsing-nmredata-file-associated-with-bruker-zip-file
branch
from
888d820 to
f2aa254
Compare
jobo322
deleted the
2647-issues-parsing-nmredata-file-associated-with-bruker-zip-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.